1. Forum
  2. FidoNet
  3. python

  • Pygate Version 1.5.18

    From Tommi Koivula@2:221/1 to Stephen Walsh on Sunday, July 19, 2026 09:55:28

    Hi Stephen,

    I updated Pygate from 1.5.15 to 1.5.18 and noticed that it was not reading X-Comment-To anymore when doing news->ftn.

    My diff:

    tommi@mxo:/src/pygate/src$ diff gateway.py /src/pygate-vk3heg/src/gateway.py 806,807d805
    < ## TK ADD
    < x_comment_to = headers.get('x-comment-to', 'Unknown').strip() 827,829c825
    < ## TK CHANGE
    < ## 'to_name': area_config.get('default_to', 'All'),
    < 'to_name': x_comment_to,
    -+-

    'to_name': area_config.get('default_to', 'All'),


    'Tommi

    .
    ---
    * Origin: nntps://news.fidonet.fi (2:221/1)
  • From Stephen Walsh@3:633/280 to Tommi Koivula on Tuesday, July 21, 2026 18:50:02

    Hello Tommi!

    19 Jul 26 09:55, you wrote to me:

    I updated Pygate from 1.5.15 to 1.5.18 and noticed that it was not
    reading X-Comment-To anymore when doing news->ftn.

    'to_name': area_config.get('default_to', 'All'),


    I reverted that change, so messages on the fido side are address to "All".
    I didn't like that they had "Unknown".

    The Fido/BBS way of messages to everyone having "ALL" looks better.




    Stephen


    --- GoldED+/LNX 1.1.5-b20260304
    * Origin: Dragon's Lair ---:- dragon.vk3heg.net -:--- Prt: 6800 (3:633/280)
  • From Tommi Koivula@2:221/1.20 to Stephen Walsh on Tuesday, July 21, 2026 16:57:06
    Hello, Stephen Walsh.
    On 21/07/2026 11.54 you wrote:

    Hello Tommi!
    19 Jul 26 09:55, you wrote to me:
    I updated Pygate from 1.5.15 to 1.5.18 and noticed that it was not
    reading X-Comment-To anymore when doing news->ftn.
    'to_name': area_config.get('default_to', 'All'),
    I reverted that change, so messages on the fido side are address to "All". I didn't like that they had "Unknown".
    The Fido/BBS way of messages to everyone having "ALL" looks better.

    But that was not my point. It is not reading X-Comment-to at all. If it doesnt exist, then the default could be "All".


    --
    Tommi

    ---
    * Origin: RBB PyGate W (2:221/1.20)
  • From Stephen Walsh@3:633/280 to Tommi Koivula on Saturday, July 25, 2026 20:15:08

    Hello Tommi!

    21 Jul 26 16:57, you wrote to me:

    I reverted that change, so messages on the fido side are address
    to "All". I didn't like that they had "Unknown". The Fido/BBS way
    of messages to everyone having "ALL" looks better.

    But that was not my point. It is not reading X-Comment-to at all. If
    it doesnt exist, then the default could be "All".

    Been running on my gate for the past 24 hours, and not noticed any issues.
    Not seen any message with what the change does though. #-;


    ### Version 1.5.19 (July 24, 2026)

    #### NNTP->FidoNet honours X-Comment-To

    src/gateway.py:806-825 - `convert_nntp_to_fido()` now reads the
    `X-Comment-To` header from the NNTP article and uses it as the FidoNet `to_name` when non-empty; when missing or blank it falls back to the
    prior behaviour of `area_config.get('default_to', 'All')`.

    Rationale: v1.5.15 introduced X-Comment-To round-trip on the
    FidoNet->NNTP direction only. NNTP->FidoNet was left addressing every
    gated article to the area's `default_to` (typically "All"), which lost
    the reply-target information that Fidonet-aware newsreaders supply via X-Comment-To. Tommi Koivula (2:221/1) reported this in his echomail
    about v1.5.18. The "or default_to" fallback means articles without an X-Comment-To header keep addressing to "All" rather than the earlier
    "Unknown" placeholder that motivated the original revert.




    Stephen


    --- GoldED+/LNX 1.1.5-b20260304
    * Origin: Dragon's Lair ---:- dragon.vk3heg.net -:--- Prt: 6800 (3:633/280)