• New warnings on todays build

    From Wilfred van Velzen@2:280/464 to Eugene Subbotin on Monday, September 14, 2026 18:42:15
    Hi Eugene,

    I'm seeing some new warnings, after a git pull, and building golded today:


    [ 39%] Building CXX object goldlib/gcfg/CMakeFiles/gcfg.dir/gxmax3.cpp.o
    In file included from ~/Projects/golded-plus-utf8/goldlib/gcfg/gxmax3.cpp:38:0: ~/Projects/golded-plus-utf8/goldlib/gcfg/gs_max3.h:134:36: warning: ‘packed’ attribute ignored [-Wattributes]
    } max_option __attribute__((packed));

    ^
    [ 46%] Building CXX object goldlib/gcfg/CMakeFiles/gcfg.dir/gxwtr.cpp.o
    In file included from ~/Projects/golded-plus-utf8/goldlib/gcfg/gxwtr.cpp:36:0: ~/Projects/golded-plus-utf8/goldlib/gcfg/gs_wtr.h:184:3: warning: anonymous type with no linkage used to declare variable ‘<anonymous struct> GroupDescRecord’ with linkage [enabled by default]
    } GroupDescRecord;
    ^
    ~/Projects/golded-plus-utf8/goldlib/gcfg/gs_wtr.h:363:3: warning: anonymous type with no linkage used to declare variable ‘<anonymous struct> UserBaseRecord’ with linkage [enabled by default]
    } UserBaseRecord;
    ^


    Bye, Wilfred.

    --- FMail-lnx64 2.3.4.1-B20260520
    * Origin: FMail development HQ (2:280/464)
  • From Eugene Subbotin@2:5075/35 to Wilfred van Velzen on Monday, September 14, 2026 20:15:32
    Hello Wilfred!

    Monday September 14 2026 18:42, you wrote to me:

    [ 39%] Building CXX object
    goldlib/gcfg/CMakeFiles/gcfg.dir/gxmax3.cpp.o In file included from ~/Projects/golded-plus-utf8/goldlib/gcfg/gxmax3.cpp:38:0: ~/Projects/g olded-plus-utf8/goldlib/gcfg/gs_max3.h:134:36: warning: ‘packed’ attribute ignored [-Wattributes] } max_option __attribute__((packed));

    ^
    [ 46%] Building CXX object
    goldlib/gcfg/CMakeFiles/gcfg.dir/gxwtr.cpp.o In file included from ~/Projects/golded-plus-utf8/goldlib/gcfg/gxwtr.cpp:36:0: ~/Projects/go lded-plus-utf8/goldlib/gcfg/gs_wtr.h:184:3: warning: anonymous type
    with no linkage used to declare variable ‘<anonymous struct> GroupDescRecord’ with linkage [enabled by default] } GroupDescRecord;
    ^
    ~/Projects/golded-plus-utf8/goldlib/gcfg/gs_wtr.h:363:3: warning: anonymous type with no linkage used to declare variable ‘<anonymous struct> UserBaseRecord’ with linkage [enabled by default] } UserBaseRecord;
    ^

    All three are cosmetic and pre-date the unicode branch. In gs_max3.h the packed attribute sits after the typedef name, so it applies to the name and every compiler drops it (gcc 15 and clang say the same).
    The enum is held at 16 bits by the rsvd=32766 member anyway. The two in gs_wtr.h are the same thing twice: GroupDescRecord and UserBaseRecord are variables of anonymous structs rather than typedefs, which gcc 4.8 on Leap 42.1 reports as a type without linkage and gcc 5 and later no longer do. None of them changes the binary.

    Eugene

    ... It's full of stars!
    --- GoldED+/BSD 2.0.0-b20260912 (NetBSD 11.0 Intel Xeon Icelake)
    * Origin: FireFox Station (2:5075/35)
  • From Wilfred van Velzen@2:280/464 to Eugene Subbotin on Tuesday, September 15, 2026 10:17:58
    Hi Eugene,

    On 2026-09-14 20:15:32, you wrote to me:

    All three are cosmetic and pre-date the unicode branch. In gs_max3.h
    the packed attribute sits after the typedef name, so it applies to the name and every compiler drops it (gcc 15 and clang say the same). The
    enum is held at 16 bits by the rsvd=32766 member anyway.

    The two in gs_wtr.h are the same thing twice: GroupDescRecord and UserBaseRecord are variables of anonymous structs rather than
    typedefs, which gcc 4.8 on Leap 42.1 reports as a type without linkage
    and gcc 5 and later no longer do. None of them changes the binary.

    Ok, thanks for the clarification.

    Yesterday I also tried compiling on a more modern system with gcc 15.3.0.. The gs_wtr.h warnings were indeed gone, but I got this extra one. (I don't know if this one is from before the unicode branch)

    [ 95%] Building CXX object golded3/CMakeFiles/golded.dir/geusrbse.cpp.o ~/Projects/golded-plus-utf8/golded3/geusrbse.cpp: In member function 'virtual void guserbase::print_line(uint, uint, bool)':
    ~/Projects/golded-plus-utf8/golded3/geusrbse.cpp:239:48: warning: ignoring return value of 'std::__cxx11::basic_string<_Char
    T, _Traits, _Alloc> std::operator+(__cxx11::basic_string<_CharT, _Traits, _Alloc>&&, const _CharT*) [with _CharT = char; _Traits = char_traits<char>; _Alloc = allocator<char>]', declared with attribute 'nodiscard' [-Wunused-result]
    239 | ((useraddr = "<") + entry.iaddr) + ">";
    | ^~~
    In file included from /usr/include/c++/15/string:56,
    from /usr/include/c++/15/bits/locale_classes.h:42,
    from /usr/include/c++/15/bits/ios_base.h:43,
    from /usr/include/c++/15/ios:46,
    from /usr/include/c++/15/bits/ostream.h:43,
    from /usr/include/c++/15/ostream:42,
    from /usr/include/c++/15/iostream:43,
    from ~/Projects/golded-plus-utf8/golded3/golded.h:35,
    from ~/Projects/golded-plus-utf8/golded3/geusrbse.cpp:29: /usr/include/c++/15/bits/basic_string.h:3973:5: note: declared here
    3973 | operator+(basic_string<_CharT, _Traits, _Alloc>&& __lhs,
    | ^~~~~~~~


    Bye, Wilfred.

    --- FMail-lnx64 2.3.4.1-B20260520
    * Origin: FMail development HQ (2:280/464)
  • From Eugene Subbotin@2:5075/35 to Wilfred van Velzen on Tuesday, September 15, 2026 11:37:54
    Hello Wilfred!

    Tuesday September 15 2026 10:17, you wrote to me:

    Ok, thanks for the clarification.

    Yesterday I also tried compiling on a more modern system with gcc 15.3.0.. The gs_wtr.h warnings were indeed gone, but I got this extra one. (I don't know if this one is from before the unicode branch)

    Yeah, that’s part of the original code, too. And it’s very old, so warnings are inevitable :)

    Eugene

    ... It's full of stars!
    --- GoldED+/BSD 2.0.0-b20260912 (NetBSD 11.0 Intel Xeon Icelake)
    * Origin: FireFox Station (2:5075/35)
  • From Nick Boel@1:154/10 to Wilfred van Velzen on Tuesday, September 15, 2026 10:47:12
    Hey Wilfred!

    On Tue, Sep 15 2026 10:17:58 +0200, Wilfred van Velzen wrote to Eugene Subbotin:

    Yesterday I also tried compiling on a more modern system with gcc
    15.3.0.. The gs_wtr.h warnings were indeed gone, but I got this extra
    one. (I don't know if this one is from before the unicode branch)

    Be glad you're only seeing a few or less warnings. Using GNU make with gcc 16.2.1, there are hundreds of them (a lot of the same ones over and over, though). There has always been a large number of warnings with Golded, as long as I've used it. As long as it compiles without error, it seems to work. ;)

    Regards,
    Nick

    ... Take my advice, I don't use it anyway.
    --- AmberEdit/linux 0.8.5
    * Origin: thePharcyde_ telnet://bbs.pharcyde.org (Wisconsin) (1:154/10)
  • From Wilfred van Velzen@2:280/464 to Nick Boel on Tuesday, September 15, 2026 18:33:59
    Hi Nick,

    On 2026-09-15 10:47:12, you wrote to me:

    Yesterday I also tried compiling on a more modern system with gcc
    15.3.0.. The gs_wtr.h warnings were indeed gone, but I got this extra
    one. (I don't know if this one is from before the unicode branch)

    Be glad you're only seeing a few or less warnings. Using GNU make with gcc 16.2.1, there are hundreds of them (a lot of the same ones over and over, though).

    I'm using cmake on both the old and new system. It give only 3 warnings for the compiling fase, and a few more for the linking.

    Apparently cmake surpresses a lot of warnings...

    There has always been a large number of warnings with Golded, as long
    as I've used it. As long as it compiles without error, it seems to
    work. ;)

    Indeed... ;-)


    Bye, Wilfred.

    --- FMail-lnx64 2.3.4.1-B20260520
    * Origin: FMail development HQ (2:280/464)